Vdsm TODO
What Can You Do for Vdsm
We intend to move this TODO into this Trello board, please check for tasks in it.
Cleanup
infra
-
pylint -E `git ls-files | grep '.py$'`
makes me cry. A lot of it is “only” about bad style, but we should clear it up and add it to ourmake check-local
. We should grow up and passpychecker
too. - Add git submodules for pyflakes and pep8 to vdsm. Control the specific version of each tool to use from within the vdsm build itself. This way we can make sure everyone is using the same version of the tools regardless of where vdsm is being built.
- BindingXML’s wrapApiMethod is incredibly fragile when deciding what not to log. Logging should be done as a decorator per called function, after password entries are converted to ProtectedPassword.
Testing
-
Add
`make distcheck`
to GitHub actions. -
Wrap all tests and fail a test that leaves an open file descriptor behind.
-
add a unit test for
qemuimg.rebase
. -
make
@permutations
nestable -
test
fileSD.scanDomains()
-
add migration tests
-
test
cannonizeHostPort
Features
-
Support striping for disk images.
-
let Vdsm install and run on hosts with no iscsid (report that iscsi is missing to Engine?)
-
start Vdsm only when it receives a request (integrate with systemd)
Networking
-
Modify vdsm-tool restore-nets so that the management network (or the network with the default IPv4 route) is the last to be taken down and the first to be taken up to minimize the connectivity loss (very useful when accessing the machine remotely). Minimize vdsm-restore-net-config downtime for the default route network.
-
Split off the network restoration from vdsm startup so that it is performed in a different init service. This vdsm-network-restoration service should be oneshot and happen before network.service. http://gerrit.ovirt.org/#/c/29441/ -
Fine-grained control on network-specific routes.
-
Allow multiple setting IPv4 and IPv6 addresses per network device. (API change is needed; we report multiple ipv6 addresses).
-
models: support multiple IPv4 and/or IPv6 addresses
-
get a single dump of all libvirt networks (no libvirt API for it yet…)
- IPv4 routing table Id hash mechanism
- change the ‘network’ argument in routes to ‘link scope route’
-
move source routing info to route.py (which uses netlink instead of using the default configurator). this will also simplify StaticSourceRoute
-
Move vdsm-store-net-config logic to netconfbackpersistence.py
- Add configureIp to the configurators API so that Layer 3 can be configured in parallel after Layer 2 (and it gives much better modelling). Obviously, this isn’t really possible in ifcfg without doing a two step write which is an ugly hack.
refactoring
-
In vm.py, libvirtvm.py, clientIF.py there is a mess of prepare*Path functions (end their respective teardowns), which is too complex to fathom. We have to convert all drive specifications (PDIV,GUID,path) into Drive object at the API entry.
-
lvm.PV.guid is devicemapper-owned piece of information; lvm has nothing to do with it, and jumps through hoops to produce it. Instead, it should be produced by devicemapper and consumed directly by blockSD.
Issues
- pick one of the open issues, post a pull request to GitHub, and make the issue yours.